Add button event to preliminary sidebar styling#1321
Closed
jamesmisson wants to merge 17 commits intoUniversalViewer:devfrom
Closed
Add button event to preliminary sidebar styling#1321jamesmisson wants to merge 17 commits intoUniversalViewer:devfrom
jamesmisson wants to merge 17 commits intoUniversalViewer:devfrom
Conversation
…imeout to account for transition time
…isplayed all the time, with other css handling visibility
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamesmisson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all types and components for the original more info dialog box and makes that button trigger the right panel to open. To do so I've added a new event, TOGGLE_MOREINFO_RIGHT_PANEL (NB the existing similarly named event TOGGLE_EXPAND_RIGHT_PANEL is for when the expandable panels are full width, e.g. gallery view for the left panel).
I've then merged Jonathan's re-styling in #1320